#212 Demo workflow: add frontend empty-state message for form list#215
#212 Demo workflow: add frontend empty-state message for form list#215codingdud wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves the Form component by replacing a console log with a user-friendly message when no forms are available. The review feedback correctly suggests changing the display style of the 'Create Form' header from 'inline' to 'inline-block' to ensure the vertical margins are applied properly in CSS.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| else if (data === undefined || data.length === 0) { | ||
| return ( | ||
| <div className="sub"><h1 style={{"display":"inline","margin":"10px"}}>Create Form</h1>{console.log("nodata")} | ||
| <div className="sub"><h1 style={{"display":"inline","margin":"10px"}}>Create Form</h1> |
There was a problem hiding this comment.
Applying a vertical margin to an element with display: inline does not work as expected in CSS, because vertical margins (top and bottom) are ignored on non-replaced inline elements. To ensure the 10px margin is applied correctly on all sides, consider changing the display property to inline-block.
| <div className="sub"><h1 style={{"display":"inline","margin":"10px"}}>Create Form</h1> | |
| <div className="sub"><h1 style={{"display":"inline-block","margin":"10px"}}>Create Form</h1> |
2 participants
Closes #212
Summary
Validation
px eslint src/components/form/form.js could not run because frontend dependencies are not installed
pm test -- --watchAll=false could not run because
eact-scripts is missing
pm run build could not run because
eact-scripts is missing